Travis updates and tweaks #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that long-running tests that are allowed to fail don't hold up the build being marked as finished, if all the required tests have passed.
Move to Xenial, which allows us to test with later OpenJDKs. Moving to Bionic would be nice but it no longer has OpenJDK 8, which is still in support.
OpenJDK 8 is now out of (commercial) support. Leave a version testing with OpenJDK 8 as it's still in free support for another year.
jdleesmiller
approved these changes
Oct 27, 2019
There was a problem hiding this comment.
OK by me 👍. Thanks for the tidy up.
We were held on trusty to keep rbx building (albeit still failing), after #399 / rubinius/rubinius#3811. However, it seems that the rbx build is still broken on xenial several months later, so given that there's now a reason to move on to xenial, I think it's OK to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
fast_finishso that builds are marked as complete as soon as possible.It still tests with OpenJDK 8 as it's still in support.